Commit 0915750e authored Jan 20, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Apr 15, 2022

power: reset: gemini-poweroff: Fix IRQ check in gemini_poweroff_probe



[ Upstream commit ba18dad0fb880cd29aa97b6b75560ef14d1061ba ]

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: f7a388d6 ("power: reset: Add a driver for the Gemini poweroff")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent dc1ea1df

drivers/power/reset/gemini-poweroff.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -107,8 +107,8 @@ static int gemini_poweroff_probe(struct platform_device *pdev)
		return PTR_ERR(gpw->base);

		irq = platform_get_irq(pdev, 0);
		if (!irq)
		return -EINVAL;
		if (irq < 0)
		return irq;

		gpw->dev = dev;