Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db3a61ef authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

power: supply: ab8500: Fix memory leak in ab8500_fg_sysfs_init 



[ Upstream commit 6a4760463dbc6b603690938c468839985189ce0a ]

kobject_init_and_add() takes reference even when it fails.
According to the doc of kobject_init_and_add()：

   If this function returns an error, kobject_put() must be called to
   properly clean up the memory associated with the object.

Fix memory leak by calling kobject_put().

Fixes: 8c0984e5 ("power: move power supply drivers to power/supply")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent df56cdeb

drivers/power/supply/ab8500_fg.c

+3 −1
Original line number Diff line number Diff line
@@ -2541,8 +2541,10 @@ static int ab8500_fg_sysfs_init(struct ab8500_fg *di) 
	ret = kobject_init_and_add(&di->fg_kobject,

		&ab8500_fg_ktype,

		NULL, "battery");

	if (ret < 0)

	if (ret < 0) {

		kobject_put(&di->fg_kobject);

		dev_err(di->dev, "failed to create sysfs entry\n");

	}



	return ret;

}