Commit d0b3ed41 authored Dec 21, 2015 by Julia Lawall Committed by Linus Walleij Dec 22, 2015

pinctrl: sh-pfc: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so a
goto out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
local idexpression n;
expression e,e1;
identifier l;
@@

 for_each_child_of_node(e1,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
   return n;
|
+  of_node_put(n);
?  goto l;
)
   ...
 }
l: ... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 2d98023c

drivers/pinctrl/sh-pfc/pinctrl.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -273,9 +273,11 @@ static int sh_pfc_dt_node_to_map(struct pinctrl_dev *pctldev,
	for_each_child_of_node(np, child) {		for_each_child_of_node(np, child) {
	ret = sh_pfc_dt_subnode_to_map(pctldev, child, map, num_maps,		ret = sh_pfc_dt_subnode_to_map(pctldev, child, map, num_maps,
	&index);		&index);
	if (ret < 0)		if (ret < 0) {
			of_node_put(child);
	goto done;		goto done;
	}		}
			}

	/* If no mapping has been found in child nodes try the config node. */		/* If no mapping has been found in child nodes try the config node. */
	if (*num_maps == 0) {		if (*num_maps == 0) {