Commit 2d98023c authored Dec 21, 2015 by Julia Lawall Committed by Linus Walleij Dec 22, 2015

pinctrl: sirf: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so a
return from the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
local idexpression n;
expression e,e1;
@@

 for_each_child_of_node(e1,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 21a8fe88

drivers/pinctrl/sirf/pinctrl-sirf.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -85,12 +85,16 @@ static int sirfsoc_dt_node_to_map(struct pinctrl_dev *pctldev,
		/* calculate number of maps required */
		for_each_child_of_node(np_config, np) {
		ret = of_property_read_string(np, "sirf,function", &function);
		if (ret < 0)
		if (ret < 0) {
		of_node_put(np);
		return ret;
		}

		ret = of_property_count_strings(np, "sirf,pins");
		if (ret < 0)
		if (ret < 0) {
		of_node_put(np);
		return ret;
		}

		count += ret;
		}