Commit 21a8fe88 authored Dec 21, 2015 by Julia Lawall Committed by Linus Walleij Dec 22, 2015

pinctrl-tegra: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so a
return from the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
local idexpression n;
expression e,e1;
@@

 for_each_child_of_node(e1,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 0eccc9cb

drivers/pinctrl/pinctrl-tegra-xusb.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -253,9 +253,11 @@ static int tegra_xusb_padctl_dt_node_to_map(struct pinctrl_dev *pinctrl,
		err = tegra_xusb_padctl_parse_subnode(padctl, np, maps,
		&reserved_maps,
		num_maps);
		if (err < 0)
		if (err < 0) {
		of_node_put(np);
		return err;
		}
		}

		return 0;
		}

drivers/pinctrl/pinctrl-tegra.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -217,6 +217,7 @@ static int tegra_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
		if (ret < 0) {
		pinctrl_utils_dt_free_map(pctldev, *map,
		*num_maps);
		of_node_put(np);
		return ret;
		}
		}