Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7262aaa authored by Johan Hovold's avatar Johan Hovold Committed by David S. Miller
Browse files

net: ethernet: ti: cpsw: fix device and of_node leaks 



Make sure to drop the references taken by of_get_child_by_name() and
bus_find_device() before returning from cpsw_phy_sel().

Note that holding a reference to the cpsw-phy-sel device does not
prevent the devres-managed private data from going away.

Fixes: 5892cd13 ("drivers: net: cpsw-phy-sel: Add new driver...")
Cc: Mugunthan V N <mugunthanvnm@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 17ae1c65

drivers/net/ethernet/ti/cpsw-phy-sel.c

+3 −0
Original line number Diff line number Diff line
@@ -176,9 +176,12 @@ void cpsw_phy_sel(struct device *dev, phy_interface_t phy_mode, int slave) 
	}



	dev = bus_find_device(&platform_bus_type, NULL, node, match);

	of_node_put(node);

	priv = dev_get_drvdata(dev);



	priv->cpsw_phy_sel(priv, phy_mode, slave);



	put_device(dev);

}

EXPORT_SYMBOL_GPL(cpsw_phy_sel);