Commit 17ae1c65 authored Nov 03, 2016 by Johan Hovold Committed by David S. Miller Nov 07, 2016

phy: fix device reference leaks



Make sure to drop the reference taken by bus_find_device_by_name()
before returning from phy_connect() and phy_attach().

Note that both function still take a reference to the phy device
through phy_attach_direct().

Fixes: e1393456 ("[PATCH] PHY Layer fixup")
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6a0c9f68

drivers/net/phy/phy_device.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -723,6 +723,7 @@ struct phy_device phy_connect(struct net_device dev, const char *bus_id,
		phydev = to_phy_device(d);

		rc = phy_connect_direct(dev, phydev, handler, interface);
		put_device(d);
		if (rc)
		return ERR_PTR(rc);

		@@ -953,6 +954,7 @@ struct phy_device phy_attach(struct net_device dev, const char *bus_id,
		phydev = to_phy_device(d);

		rc = phy_attach_direct(dev, phydev, phydev->dev_flags, interface);
		put_device(d);
		if (rc)
		return ERR_PTR(rc);