Commit c214455f authored Jan 20, 2012 by Marc Zyngier Committed by Russell King Jan 23, 2012

ARM: 7297/1: smp_twd: make sure timer is stopped before registering it



On secondary CPUs, the Timer Control Register is not reset
to a sane value before the timer is registered, and the TRM
doesn't seem to indicate any reset value either. In some cases,
the kernel will take an interrupt too early, depending on what
junk was present in the registers at reset time.

The fix is to set the Timer Control Register to 0 before
registering the clock_event_device and enabling the interrupt.

Problem seen on VE (Cortex A5) and Tegra.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

parent 612539e8

arch/arm/kernel/smp_twd.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -252,6 +252,8 @@ void __cpuinit twd_timer_setup(struct clock_event_device *clk)
		else
		twd_calibrate_rate();

		__raw_writel(0, twd_base + TWD_TIMER_CONTROL);

		clk->name = "local_timer";
		clk->features = CLOCK_EVT_FEAT_PERIODIC \| CLOCK_EVT_FEAT_ONESHOT \|
		CLOCK_EVT_FEAT_C3STOP;