Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bdb94346 authored by Marcel Holtmann's avatar Marcel Holtmann
Browse files

Bluetooth: Fix sparse warning from HID new leds handling 



The new leds bit handling produces this spares warning.

  CHECK   net/bluetooth/hidp/core.c
net/bluetooth/hidp/core.c:156:60: warning: dubious: x | !y

Just fix it by doing an explicit x << 0 shift operation.

Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
parent 6f78fd4b

net/bluetooth/hidp/core.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -154,7 +154,7 @@ static int hidp_input_event(struct input_dev *dev, unsigned int type, 
		  (!!test_bit(LED_COMPOSE, dev->led) << 3) |

		  (!!test_bit(LED_COMPOSE, dev->led) << 3) |

		  (!!test_bit(LED_SCROLLL, dev->led) << 2) |

		  (!!test_bit(LED_SCROLLL, dev->led) << 2) |

		  (!!test_bit(LED_CAPSL,   dev->led) << 1) |

		  (!!test_bit(LED_CAPSL,   dev->led) << 1) |

		  (!!test_bit(LED_NUML,    dev->led));

		  (!!test_bit(LED_NUML,    dev->led) << 0);





	if (session->leds == newleds)

	if (session->leds == newleds)

		return 0;

		return 0;