HID: alps: Fix an error handling path in 'alps_input_configured()'
commit 8d2e77b39b8fecb794e19cd006a12f90b14dd077 upstream.
They are issues:
- if 'input_allocate_device()' fails and return NULL, there is no need
to free anything and 'input_free_device()' call is a no-op. It can
be axed.
- 'ret' is known to be 0 at this point, so we must set it to a
meaningful value before returning
Fixes: 2562756d ("HID: add Alps I2C HID Touchpad-Stick support")
Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by:
Jiri Kosina <jkosina@suse.cz>
Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Loading
Please register or sign in to comment