Commit b2cde935 authored Jun 15, 2020 by Navid Emamdoost Committed by Greg Kroah-Hartman Jul 22, 2020

drm/exynos: fix ref count leak in mic_pre_enable



[ Upstream commit d4f5a095daf0d25f0b385e1ef26338608433a4c5 ]

in mic_pre_enable, pm_runtime_get_sync is called which
increments the counter even in case of failure, leading to incorrect
ref count. In case of failure, decrement the ref count before returning.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent bf59aa00

drivers/gpu/drm/exynos/exynos_drm_mic.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -267,8 +267,10 @@ static void mic_pre_enable(struct drm_bridge *bridge)
		goto unlock;

		ret = pm_runtime_get_sync(mic->dev);
		if (ret < 0)
		if (ret < 0) {
		pm_runtime_put_noidle(mic->dev);
		goto unlock;
		}

		mic_set_path(mic, 1);