Commit bf59aa00 authored Jun 12, 2020 by Bernard Zhao Committed by Greg Kroah-Hartman Jul 22, 2020

drm/msm: fix potential memleak in error branch



[ Upstream commit 177d3819633cd520e3f95df541a04644aab4c657 ]

In function msm_submitqueue_create, the queue is a local
variable, in return -EINVAL branch, queue didn`t add to ctx`s
list yet, and also didn`t kfree, this maybe bring in potential
memleak.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
[trivial commit msg fixup]
Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d4d0e6c0

drivers/gpu/drm/msm/msm_submitqueue.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -78,8 +78,10 @@ int msm_submitqueue_create(struct drm_device drm, struct msm_file_private ctx,
		queue->flags = flags;

		if (priv->gpu) {
		if (prio >= priv->gpu->nr_rings)
		if (prio >= priv->gpu->nr_rings) {
		kfree(queue);
		return -EINVAL;
		}

		queue->prio = prio;
		}