Commit ab6815d0 authored Mar 23, 2018 by Tudor-Dan Ambarus Committed by Herbert Xu Mar 31, 2018

crypto: qat - don't leak pointers to authenc keys



In qat_alg_aead_init_sessions we save pointers to the authenc keys
in a local variable of type struct crypto_authenc_keys and we don't
zeroize it after use. Fix this and don't leak pointers to the
authenc keys.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent a664b4b1

drivers/crypto/qat/qat_common/qat_algs.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -546,11 +546,14 @@ static int qat_alg_aead_init_sessions(struct crypto_aead tfm, const u8 key,
		if (qat_alg_aead_init_dec_session(tfm, alg, &keys, mode))
		goto error;

		memzero_explicit(&keys, sizeof(keys));
		return 0;
		bad_key:
		crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN);
		memzero_explicit(&keys, sizeof(keys));
		return -EINVAL;
		error:
		memzero_explicit(&keys, sizeof(keys));
		return -EFAULT;
		}