Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a664b4b1 authored by Tudor-Dan Ambarus's avatar Tudor-Dan Ambarus Committed by Herbert Xu
Browse files

crypto: picoxcell - don't leak pointers to authenc keys 



In spacc_aead_setkey we save pointers to the authenc keys in a
local variable of type struct crypto_authenc_keys and we don't
zeroize it after use. Fix this and don't leak pointers to the
authenc keys.

Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: default avatarJamie Iles <jamie@jamieiles.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 0e7da29d

drivers/crypto/picoxcell_crypto.c

+2 −0
Original line number Diff line number Diff line
@@ -499,10 +499,12 @@ static int spacc_aead_setkey(struct crypto_aead *tfm, const u8 *key, 
	memcpy(ctx->hash_ctx, keys.authkey, keys.authkeylen);

	ctx->hash_key_len = keys.authkeylen;



	memzero_explicit(&keys, sizeof(keys));

	return 0;



badkey:

	crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN);

	memzero_explicit(&keys, sizeof(keys));

	return -EINVAL;

}