Commit a897f54e authored Mar 01, 2019 by Sven Van Asbroeck Committed by Greg Kroah-Hartman Nov 06, 2019

PCI/PME: Fix possible use-after-free on remove



[ Upstream commit 7cf58b79b3072029af127ae865ffc6f00f34b1f8 ]

In remove(), ensure that the PME work cannot run after kfree() is called.
Otherwise, this could result in a use-after-free.

This issue was detected with the help of Coccinelle.

Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Sinan Kaya <okaya@kernel.org>
Cc: Frederick Lawler <fred@fredlawl.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 0e23eeb0

drivers/pci/pcie/pme.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -437,6 +437,7 @@ static void pcie_pme_remove(struct pcie_device *srv)

		pcie_pme_disable_interrupt(srv->port, data);
		free_irq(srv->irq, srv);
		cancel_work_sync(&data->work);
		kfree(data);
		}