Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e23eeb0 authored by Andrew Lunn's avatar Andrew Lunn Committed by Greg Kroah-Hartman
Browse files

net: dsa: mv88e6xxx: Release lock while requesting IRQ 



[ Upstream commit 342a0ee70acbee97fdeb91349420f8744eb291fb ]

There is no need to hold the register lock while requesting the GPIO
interrupt. By not holding it we can also avoid a false positive
lockdep splat.

Reported-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 646e5c77

drivers/net/dsa/mv88e6xxx/chip.c

+2 −0
Original line number Diff line number Diff line
@@ -456,10 +456,12 @@ static int mv88e6xxx_g1_irq_setup(struct mv88e6xxx_chip *chip) 
	 */

	irq_set_lockdep_class(chip->irq, &lock_key, &request_key);



	mutex_unlock(&chip->reg_lock);

	err = request_threaded_irq(chip->irq, NULL,

				   mv88e6xxx_g1_irq_thread_fn,

				   IRQF_ONESHOT,

				   dev_name(chip->dev), chip);

	mutex_lock(&chip->reg_lock);

	if (err)

		mv88e6xxx_g1_irq_free_common(chip);