Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a6cab7d7 authored by Alexander Duyck's avatar Alexander Duyck Committed by Jeff Kirsher
Browse files

i40evf: Drop i40evf_fire_sw_int as it is prone to races 



Having the interrupts firing while we are polling causes extra overhead and
isn't needed for most systems out there. If an interrupt is lost us
experiencing a 2s latency spike before recovering is still not acceptable
and masks the issue. We are better off just identifying systems that lose
interrupts and instead enable workarounds for those systems.

To that end I am dropping the code that was strobing the interrupts as
there is a narrow window where having them enabled can actually cause
race issues anyway where a few stray packets might get misses if the
interrupt is re-enabled and fires before we call napi_complete.

Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent f23735aa

drivers/net/ethernet/intel/i40evf/i40evf_main.c

+0 −34
Original line number Diff line number Diff line
@@ -281,33 +281,6 @@ void i40evf_irq_enable_queues(struct i40evf_adapter *adapter, u32 mask) 
	}

}



/**

 * i40evf_fire_sw_int - Generate SW interrupt for specified vectors

 * @adapter: board private structure

 * @mask: bitmap of vectors to trigger

 **/

static void i40evf_fire_sw_int(struct i40evf_adapter *adapter, u32 mask)

{

	struct i40e_hw *hw = &adapter->hw;

	int i;

	u32 dyn_ctl;



	if (mask & 1) {

		dyn_ctl = rd32(hw, I40E_VFINT_DYN_CTL01);

		dyn_ctl |= I40E_VFINT_DYN_CTLN1_SWINT_TRIG_MASK |

			   I40E_VFINT_DYN_CTLN1_ITR_INDX_MASK;

		wr32(hw, I40E_VFINT_DYN_CTL01, dyn_ctl);

	}

	for (i = 1; i < adapter->num_msix_vectors; i++) {

		if (mask & BIT(i)) {

			dyn_ctl = rd32(hw, I40E_VFINT_DYN_CTLN1(i - 1));

			dyn_ctl |= I40E_VFINT_DYN_CTLN1_SWINT_TRIG_MASK |

				   I40E_VFINT_DYN_CTLN1_ITR_INDX_MASK;

			wr32(hw, I40E_VFINT_DYN_CTLN1(i - 1), dyn_ctl);

		}

	}

}



/**

 * i40evf_irq_enable - Enable default interrupt generation settings

 * @adapter: board private structure
@@ -1743,13 +1716,6 @@ static void i40evf_watchdog_task(struct work_struct *work) 
	if (adapter->state == __I40EVF_RUNNING)

		i40evf_request_stats(adapter);

watchdog_done:

	if (adapter->state == __I40EVF_RUNNING) {

		i40evf_irq_enable_queues(adapter, ~0);

		i40evf_fire_sw_int(adapter, 0xFF);

	} else {

		i40evf_fire_sw_int(adapter, 0x1);

	}



	clear_bit(__I40EVF_IN_CRITICAL_TASK, &adapter->crit_section);

restart_watchdog:

	if (adapter->state == __I40EVF_REMOVE)