Commit f23735aa authored Nov 14, 2017 by Alexander Duyck Committed by Jeff Kirsher Jan 10, 2018

i40evf: Clean-up flags for promisc mode to avoid high polling rate

If you enabled and disabled promiscuous mode on a VF you could easily put
it into a state where it would start firing interrupts on all queues at a
rate of 50+ interrupts per second even though there was no traffic present.
The issue seems to have been a stray admin queue feature flag set that was
leaving us in a high polling rate for the adminq task.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 498860cf

drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -739,8 +739,10 @@ void i40evf_set_promiscuous(struct i40evf_adapter *adapter, int flags)
		}

		if (!flags) {
		adapter->flags &= ~I40EVF_FLAG_PROMISC_ON;
		adapter->aq_required &= ~I40EVF_FLAG_AQ_RELEASE_PROMISC;
		adapter->flags &= ~(I40EVF_FLAG_PROMISC_ON \|
		I40EVF_FLAG_ALLMULTI_ON);
		adapter->aq_required &= ~(I40EVF_FLAG_AQ_RELEASE_PROMISC \|
		I40EVF_FLAG_AQ_RELEASE_ALLMULTI);
		dev_info(&adapter->pdev->dev, "Leaving promiscuous mode\n");
		}