Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ed59600 authored by Xiaolong Huang's avatar Xiaolong Huang Committed by Greg Kroah-Hartman
Browse files

can: kvaser_usb: kvaser_usb_leaf: Fix some info-leaks to USB devices 



commit da2311a6385c3b499da2ed5d9be59ce331fa93e9 upstream.

Uninitialized Kernel memory can leak to USB devices.

Fix this by using kzalloc() instead of kmalloc().

Signed-off-by: default avatarXiaolong Huang <butterflyhuangxx@gmail.com>
Fixes: 7259124e ("can: kvaser_usb: Split driver into kvaser_usb_core.c and kvaser_usb_leaf.c")
Cc: linux-stable <stable@vger.kernel.org> # >= v4.19
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b5e8f394

drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c

+3 −3
Original line number Diff line number Diff line
@@ -608,7 +608,7 @@ static int kvaser_usb_leaf_simple_cmd_async(struct kvaser_usb_net_priv *priv, 
	struct kvaser_cmd *cmd;

	int err;



	cmd = kmalloc(sizeof(*cmd), GFP_ATOMIC);

	cmd = kzalloc(sizeof(*cmd), GFP_ATOMIC);

	if (!cmd)

		return -ENOMEM;
@@ -1140,7 +1140,7 @@ static int kvaser_usb_leaf_set_opt_mode(const struct kvaser_usb_net_priv *priv) 
	struct kvaser_cmd *cmd;

	int rc;



	cmd = kmalloc(sizeof(*cmd), GFP_KERNEL);

	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);

	if (!cmd)

		return -ENOMEM;
@@ -1206,7 +1206,7 @@ static int kvaser_usb_leaf_flush_queue(struct kvaser_usb_net_priv *priv) 
	struct kvaser_cmd *cmd;

	int rc;



	cmd = kmalloc(sizeof(*cmd), GFP_KERNEL);

	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);

	if (!cmd)

		return -ENOMEM;