Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d0aaf42 authored by Daniel Thompson's avatar Daniel Thompson Committed by Sasha Levin
Browse files

backlight: lm3639: Fully initialize backlight_properties during probe 



[ Upstream commit abb5a5d951fbea3feb5c4ba179b89bb96a1d3462 ]

props is stack allocated and the fields that are not explcitly set
by the probe function need to be zeroed or we'll get undefined behaviour
(especially so power/blank states)!

Fixes: 0f59858d ("backlight: add new lm3639 backlight driver")
Signed-off-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240220153532.76613-3-daniel.thompson@linaro.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ba9f50fa

drivers/video/backlight/lm3639_bl.c

+1 −0
Original line number Diff line number Diff line
@@ -343,6 +343,7 @@ static int lm3639_probe(struct i2c_client *client, 
	}



	/* backlight */

	memset(&props, 0, sizeof(struct backlight_properties));

	props.type = BACKLIGHT_RAW;

	props.brightness = pdata->init_brt_led;

	props.max_brightness = pdata->max_brt_led;