Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9bcc7be7 authored by Takashi Iwai's avatar Takashi Iwai Committed by Greg Kroah-Hartman
Browse files

ALSA: hda: Drop the BATCH workaround for AMD controllers 

commit 28e96c1693ec1cdc963807611f8b5ad400431e82 upstream.

The commit c02f77d32d2c ("ALSA: hda - Workaround for crackled sound on
AMD controller (1022:1457)") introduced a few workarounds for the
recent AMD HD-audio controller, and one of them is the forced BATCH
PCM mode so that PulseAudio avoids the timer-based scheduling.  This
was thought to cover for some badly working applications, but this
actually worsens for more others.  In total, this wasn't a good idea
to enforce it.

This is a partial revert of the commit above for dropping the PCM
BATCH enforcement part to recover from the regression again.

Fixes: c02f77d32d2c ("ALSA: hda - Workaround for crackled sound on AMD controller (1022:1457)")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=195303
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210308160726.22930-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e8cc748c

sound/pci/hda/hda_controller.c

+0 −7
Original line number Diff line number Diff line
@@ -624,13 +624,6 @@ static int azx_pcm_open(struct snd_pcm_substream *substream) 
				     20,

				     178000000);



	/* by some reason, the playback stream stalls on PulseAudio with

	 * tsched=1 when a capture stream triggers.  Until we figure out the

	 * real cause, disable tsched mode by telling the PCM info flag.

	 */

	if (chip->driver_caps & AZX_DCAPS_AMD_WORKAROUND)

		runtime->hw.info |= SNDRV_PCM_INFO_BATCH;



	if (chip->align_buffer_size)

		/* constrain buffer sizes to be multiple of 128

		   bytes. This is more efficient in terms of memory