Commit e8cc748c authored Mar 10, 2021 by Takashi Iwai Committed by Greg Kroah-Hartman Mar 17, 2021

ALSA: hda/hdmi: Cancel pending works before suspend

commit eea46a0879bcca23e15071f9968c0f6e6596e470 upstream.

The per_pin->work might be still floating at the suspend, and this may
hit the access to the hardware at an unexpected timing.  Cancel the
work properly at the suspend callback for avoiding the buggy access.

Note that the bug doesn't trigger easily in the recent kernels since
the work is queued only when the repoll count is set, and usually it's
only at the resume callback, but it's still possible to hit in
theory.

BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1182377


Reported-and-tested-by: Abhishek Sahu <abhsahu@nvidia.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210310112809.9215-4-tiwai@suse.de


Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8e051ec2

sound/pci/hda/patch_hdmi.c

+13 −0

Original line number	Diff line number	Diff line
		@@ -2326,6 +2326,18 @@ static void generic_hdmi_free(struct hda_codec *codec)
		}

		#ifdef CONFIG_PM
		static int generic_hdmi_suspend(struct hda_codec *codec)
		{
		struct hdmi_spec *spec = codec->spec;
		int pin_idx;

		for (pin_idx = 0; pin_idx < spec->num_pins; pin_idx++) {
		struct hdmi_spec_per_pin *per_pin = get_pin(spec, pin_idx);
		cancel_delayed_work_sync(&per_pin->work);
		}
		return 0;
		}

		static int generic_hdmi_resume(struct hda_codec *codec)
		{
		struct hdmi_spec *spec = codec->spec;
		@@ -2349,6 +2361,7 @@ static const struct hda_codec_ops generic_hdmi_patch_ops = {
		.build_controls = generic_hdmi_build_controls,
		.unsol_event = hdmi_unsol_event,
		#ifdef CONFIG_PM
		.suspend = generic_hdmi_suspend,
		.resume = generic_hdmi_resume,
		#endif
		};