Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 815a7141 authored by Johan Hovold's avatar Johan Hovold Committed by Michael Ellerman
Browse files

powerpc/ibmebus: Fix further device reference leaks 



Make sure to drop any reference taken by bus_find_device() when creating
devices during init and driver registration.

Fixes: 55347cc9 ("[POWERPC] ibmebus: Add device creation and bus probing based on of_device")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent fe0f3168

arch/powerpc/kernel/ibmebus.c

+6 −2
Original line number Diff line number Diff line
@@ -180,6 +180,7 @@ static int ibmebus_create_device(struct device_node *dn) 
static int ibmebus_create_devices(const struct of_device_id *matches)

{

	struct device_node *root, *child;

	struct device *dev;

	int ret = 0;



	root = of_find_node_by_path("/");
@@ -188,9 +189,12 @@ static int ibmebus_create_devices(const struct of_device_id *matches) 
		if (!of_match_node(matches, child))

			continue;



		if (bus_find_device(&ibmebus_bus_type, NULL, child,

				    ibmebus_match_node))

		dev = bus_find_device(&ibmebus_bus_type, NULL, child,

				      ibmebus_match_node);

		if (dev) {

			put_device(dev);

			continue;

		}



		ret = ibmebus_create_device(child);

		if (ret) {