Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fe0f3168 authored by Johan Hovold's avatar Johan Hovold Committed by Michael Ellerman
Browse files

powerpc/ibmebus: Fix device reference leaks in sysfs interface 



Make sure to drop any reference taken by bus_find_device() in the sysfs
callbacks that are used to create and destroy devices based on
device-tree entries.

Fixes: 6bccf755 ("[POWERPC] ibmebus: dynamic addition/removal of adapters, some code cleanup")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 9e4f51bd

arch/powerpc/kernel/ibmebus.c

+6 −2
Original line number Diff line number Diff line
@@ -262,6 +262,7 @@ static ssize_t ibmebus_store_probe(struct bus_type *bus, 
				   const char *buf, size_t count)

{

	struct device_node *dn = NULL;

	struct device *dev;

	char *path;

	ssize_t rc = 0;
@@ -269,8 +270,10 @@ static ssize_t ibmebus_store_probe(struct bus_type *bus, 
	if (!path)

		return -ENOMEM;



	if (bus_find_device(&ibmebus_bus_type, NULL, path,

			    ibmebus_match_path)) {

	dev = bus_find_device(&ibmebus_bus_type, NULL, path,

			      ibmebus_match_path);

	if (dev) {

		put_device(dev);

		printk(KERN_WARNING "%s: %s has already been probed\n",

		       __func__, path);

		rc = -EEXIST;
@@ -307,6 +310,7 @@ static ssize_t ibmebus_store_remove(struct bus_type *bus, 
	if ((dev = bus_find_device(&ibmebus_bus_type, NULL, path,

				   ibmebus_match_path))) {

		of_device_unregister(to_platform_device(dev));

		put_device(dev);



		kfree(path);

		return count;