Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7fdfc702 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Tomi Valkeinen
Browse files

fbdev: n411: check return value 



We were not checking the return value of platform_device_add_data()
which can fail.

Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent f059c4b2

drivers/video/fbdev/n411.c

+9 −3
Original line number Diff line number Diff line
@@ -165,16 +165,22 @@ static int __init n411_init(void) 
	if (!n411_device)

		return -ENOMEM;



	platform_device_add_data(n411_device, &n411_board, sizeof(n411_board));

	ret = platform_device_add_data(n411_device, &n411_board,

				       sizeof(n411_board));

	if (ret)

		goto put_plat_device;



	/* this _add binds hecubafb to n411. hecubafb refcounts n411 */

	ret = platform_device_add(n411_device);



	if (ret)

		platform_device_put(n411_device);

		goto put_plat_device;



	return ret;

	return 0;



put_plat_device:

	platform_device_put(n411_device);

	return ret;

}



static void __exit n411_exit(void)