Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f059c4b2 authored by Andrzej Hajda's avatar Andrzej Hajda Committed by Tomi Valkeinen
Browse files

fbdev: exynos: fix IS_ERR_VALUE usage 

IS_ERR_VALUE macro should be used only with unsigned long type.
For signed types comparison 'ret < 0' should be used.

The patch follows conclusion from discussion on LKML [1][2].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2120927
[2]: http://permalink.gmane.org/gmane.linux.kernel/2150581



Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 206fc205

drivers/video/fbdev/exynos/exynos_mipi_dsi.c

+3 −3
Original line number Diff line number Diff line
@@ -402,12 +402,12 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev) 
		goto error;

	}



	dsim->irq = platform_get_irq(pdev, 0);

	if (IS_ERR_VALUE(dsim->irq)) {

	ret = platform_get_irq(pdev, 0);

	if (ret < 0) {

		dev_err(&pdev->dev, "failed to request dsim irq resource\n");

		ret = -EINVAL;

		goto error;

	}

	dsim->irq = ret;



	init_completion(&dsim_wr_comp);

	init_completion(&dsim_rd_comp);