Commit 7f73b9f1 authored Feb 11, 2015 by Wu Fengguang Committed by Pablo Neira Ayuso Feb 11, 2015

netfilter: ipset: fix boolreturn.cocci warnings

net/netfilter/xt_set.c:196:9-10: WARNING: return of 0/1 in function 'set_match_v3' with return type bool
net/netfilter/xt_set.c:242:9-10: WARNING: return of 0/1 in function 'set_match_v4' with return type bool

Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent 5cca4ace

net/netfilter/xt_set.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -193,7 +193,7 @@ set_match_v3(const struct sk_buff skb, struct xt_action_param par)
		return ret;

		if (!match_counter0(opt.ext.packets, &info->packets))
		return 0;
		return false;
		return match_counter0(opt.ext.bytes, &info->bytes);
		}

		@@ -239,7 +239,7 @@ set_match_v4(const struct sk_buff skb, struct xt_action_param par)
		return ret;

		if (!match_counter(opt.ext.packets, &info->packets))
		return 0;
		return false;
		return match_counter(opt.ext.bytes, &info->bytes);
		}