Commit 7bed2889 authored Jul 24, 2019 by Erqi Chen Committed by Greg Kroah-Hartman Aug 29, 2019

ceph: clear page dirty before invalidate page

commit c95f1c5f436badb9bb87e9b30fd573f6b3d59423 upstream.

clear_page_dirty_for_io(page) before mapping->a_ops->invalidatepage().
invalidatepage() clears page's private flag, if dirty flag is not
cleared, the page may cause BUG_ON failure in ceph_set_page_dirty().

Cc: stable@vger.kernel.org
Link: https://tracker.ceph.com/issues/40862


Signed-off-by: Erqi Chen <chenerqi@gmail.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a8f7703f

fs/ceph/addr.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -913,8 +913,9 @@ static int ceph_writepages_start(struct address_space *mapping,
		if (page_offset(page) >= ceph_wbc.i_size) {
		dout("%p page eof %llu\n",
		page, ceph_wbc.i_size);
		if (ceph_wbc.size_stable \|\|
		page_offset(page) >= i_size_read(inode))
		if ((ceph_wbc.size_stable \|\|
		page_offset(page) >= i_size_read(inode)) &&
		clear_page_dirty_for_io(page))
		mapping->a_ops->invalidatepage(page,
		0, PAGE_SIZE);
		unlock_page(page);