Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a9ec808 authored by Sakari Ailus's avatar Sakari Ailus Committed by Mauro Carvalho Chehab
Browse files

media: v4l: fwnode: Add convenience function for parsing common external refs 



Add v4l2_fwnode_parse_reference_sensor_common for parsing common
sensor properties that refer to adjacent devices such as flash or lens
driver chips.

As this is an association only, there's little a regular driver needs to
know about these devices as such.

Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
Reviewed-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent a1699a4e

drivers/media/v4l2-core/v4l2-fwnode.c

+35 −0
Original line number Diff line number Diff line
@@ -865,6 +865,41 @@ static int v4l2_fwnode_reference_parse_int_props( 
	return ret;

}



int v4l2_async_notifier_parse_fwnode_sensor_common(

	struct device *dev, struct v4l2_async_notifier *notifier)

{

	static const char * const led_props[] = { "led" };

	static const struct {

		const char *name;

		const char * const *props;

		unsigned int nprops;

	} props[] = {

		{ "flash-leds", led_props, ARRAY_SIZE(led_props) },

		{ "lens-focus", NULL, 0 },

	};

	unsigned int i;



	for (i = 0; i < ARRAY_SIZE(props); i++) {

		int ret;



		if (props[i].props && is_acpi_node(dev_fwnode(dev)))

			ret = v4l2_fwnode_reference_parse_int_props(

				dev, notifier, props[i].name,

				props[i].props, props[i].nprops);

		else

			ret = v4l2_fwnode_reference_parse(

				dev, notifier, props[i].name);

		if (ret && ret != -ENOENT) {

			dev_warn(dev, "parsing property \"%s\" failed (%d)\n",

				 props[i].name, ret);

			return ret;

		}

	}



	return 0;

}

EXPORT_SYMBOL_GPL(v4l2_async_notifier_parse_fwnode_sensor_common);



MODULE_LICENSE("GPL");

MODULE_AUTHOR("Sakari Ailus <sakari.ailus@linux.intel.com>");

MODULE_AUTHOR("Sylwester Nawrocki <s.nawrocki@samsung.com>");

include/media/v4l2-async.h

+2 −1
Original line number Diff line number Diff line
@@ -156,7 +156,8 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier); 
 * Release memory resources related to a notifier, including the async

 * sub-devices allocated for the purposes of the notifier but not the notifier

 * itself. The user is responsible for calling this function to clean up the

 * notifier after calling @v4l2_async_notifier_parse_fwnode_endpoints.

 * notifier after calling @v4l2_async_notifier_parse_fwnode_endpoints or

 * @v4l2_fwnode_reference_parse_sensor_common.

 *

 * There is no harm from calling v4l2_async_notifier_cleanup in other

 * cases as long as its memory has been zeroed after it has been

include/media/v4l2-fwnode.h

+21 −0
Original line number Diff line number Diff line
@@ -319,4 +319,25 @@ int v4l2_async_notifier_parse_fwnode_endpoints_by_port( 
			      struct v4l2_fwnode_endpoint *vep,

			      struct v4l2_async_subdev *asd));



/**

 * v4l2_fwnode_reference_parse_sensor_common - parse common references on

 *					       sensors for async sub-devices

 * @dev: the device node the properties of which are parsed for references

 * @notifier: the async notifier where the async subdevs will be added

 *

 * Parse common sensor properties for remote devices related to the

 * sensor and set up async sub-devices for them.

 *

 * Any notifier populated using this function must be released with a call to

 * v4l2_async_notifier_release() after it has been unregistered and the async

 * sub-devices are no longer in use, even in the case the function returned an

 * error.

 *

 * Return: 0 on success

 *	   -ENOMEM if memory allocation failed

 *	   -EINVAL if property parsing failed

 */

int v4l2_async_notifier_parse_fwnode_sensor_common(

	struct device *dev, struct v4l2_async_notifier *notifier);



#endif /* _V4L2_FWNODE_H */