Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6102c48b authored by Samuel Thibault's avatar Samuel Thibault Committed by Greg Kroah-Hartman
Browse files

staging: speakup: avoid out-of-range access in synth_add() 



Check that array index is in-bounds before accessing the synths[] array.

Signed-off-by: default avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
Cc: stable <stable@vger.kernel.org>
Cc: Nickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ae428655

drivers/staging/speakup/synth.c

+1 −1
Original line number Diff line number Diff line
@@ -423,7 +423,7 @@ int synth_add(struct spk_synth *in_synth) 
	int i;

	int status = 0;

	mutex_lock(&spk_mutex);

	for (i = 0; synths[i] != NULL && i < MAXSYNTHS; i++)

	for (i = 0; i < MAXSYNTHS && synths[i] != NULL; i++)

		/* synth_remove() is responsible for rotating the array down */

		if (in_synth == synths[i]) {

			mutex_unlock(&spk_mutex);