Commit ae428655 authored Jan 05, 2013 by Nickolai Zeldovich Committed by Greg Kroah-Hartman Jan 07, 2013

staging: speakup: avoid out-of-range access in synth_init()



Check that array index is in-bounds before accessing the synths[] array.

Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Cc: stable <stable@vger.kernel.org>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2dcb4a29

drivers/staging/speakup/synth.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -342,7 +342,7 @@ int synth_init(char *synth_name)

		mutex_lock(&spk_mutex);
		/* First, check if we already have it loaded. */
		for (i = 0; synths[i] != NULL && i < MAXSYNTHS; i++)
		for (i = 0; i < MAXSYNTHS && synths[i] != NULL; i++)
		if (strcmp(synths[i]->name, synth_name) == 0)
		synth = synths[i];