Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56c78bb3 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Dmitry Torokhov
Browse files

Input: sidewinder - mark expected switch fall-throughs 



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114763
Addresses-Coverity-ID: 114764
Addresses-Coverity-ID: 114765
Addresses-Coverity-ID: 114766
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 005161c8

drivers/input/joystick/sidewinder.c

+5 −5
Original line number Diff line number Diff line
@@ -672,16 +672,16 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv) 


			switch (i * m) {

				case 60:

					sw->number++;

					sw->number++;			/* fall through */

				case 45:				/* Ambiguous packet length */

					if (j <= 40) {			/* ID length less or eq 40 -> FSP */

				case 43:

						sw->type = SW_ID_FSP;

						break;

					}

					sw->number++;

					sw->number++;			/* fall through */

				case 30:

					sw->number++;

					sw->number++;			/* fall through */

				case 15:

					sw->type = SW_ID_GP;

					break;
@@ -697,9 +697,9 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv) 
						sw->type = SW_ID_PP;

					break;

				case 66:

					sw->bits = 3;

					sw->bits = 3;			/* fall through */

				case 198:

					sw->length = 22;

					sw->length = 22;		/* fall through */

				case 64:

					sw->type = SW_ID_3DP;

					if (j == 160)