Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 005161c8 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Dmitry Torokhov
Browse files

Input: spaceball - mark expected switch fall-throughs 



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114767
Addresses-Coverity-ID: 114768
Addresses-Coverity-ID: 114769
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 781f2dd0

drivers/input/joystick/spaceball.c

+4 −0
Original line number Diff line number Diff line
@@ -162,6 +162,7 @@ static irqreturn_t spaceball_interrupt(struct serio *serio, 
				break;

			}

			spaceball->escape = 0;

			/* fall through */

		case 'M':

		case 'Q':

		case 'S':
@@ -169,6 +170,7 @@ static irqreturn_t spaceball_interrupt(struct serio *serio, 
				spaceball->escape = 0;

				data &= 0x1f;

			}

			/* fall through */

		default:

			if (spaceball->escape)

				spaceball->escape = 0;
@@ -234,11 +236,13 @@ static int spaceball_connect(struct serio *serio, struct serio_driver *drv) 
			input_dev->keybit[BIT_WORD(BTN_A)] |= BIT_MASK(BTN_A) |

				BIT_MASK(BTN_B) | BIT_MASK(BTN_C) |

				BIT_MASK(BTN_MODE);

			/* fall through */

		default:

			input_dev->keybit[BIT_WORD(BTN_0)] |= BIT_MASK(BTN_2) |

				BIT_MASK(BTN_3) | BIT_MASK(BTN_4) |

				BIT_MASK(BTN_5) | BIT_MASK(BTN_6) |

				BIT_MASK(BTN_7) | BIT_MASK(BTN_8);

			/* fall through */

		case SPACEBALL_3003C:

			input_dev->keybit[BIT_WORD(BTN_0)] |= BIT_MASK(BTN_1) |

				BIT_MASK(BTN_8);