Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53a4c6b2 authored by Chris Wilson's avatar Chris Wilson Committed by Daniel Vetter
Browse files

drm/i915: Only print information for filing bug reports once 



Repeating the same information multiple times is just annoying.

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 3fac8978

drivers/gpu/drm/i915/i915_gpu_error.c

+8 −4
Original line number Original line Diff line number Diff line
@@ -1093,6 +1093,7 @@ static void i915_capture_reg_state(struct drm_i915_private *dev_priv, 
 */

 */

void i915_capture_error_state(struct drm_device *dev)

void i915_capture_error_state(struct drm_device *dev)

{

{

	static bool warned;

	struct drm_i915_private *dev_priv = dev->dev_private;

	struct drm_i915_private *dev_priv = dev->dev_private;

	struct drm_i915_error_state *error;

	struct drm_i915_error_state *error;

	unsigned long flags;

	unsigned long flags;
@@ -1112,10 +1113,13 @@ void i915_capture_error_state(struct drm_device *dev) 




	DRM_INFO("GPU crash dump saved to /sys/class/drm/card%d/error\n",

	DRM_INFO("GPU crash dump saved to /sys/class/drm/card%d/error\n",

		 dev->primary->index);

		 dev->primary->index);

	if (!warned) {

		DRM_INFO("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");

		DRM_INFO("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");

		DRM_INFO("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");

		DRM_INFO("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");

		DRM_INFO("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");

		DRM_INFO("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");

		DRM_INFO("The gpu crash dump is required to analyze gpu hangs, so please always attach it.\n");

		DRM_INFO("The gpu crash dump is required to analyze gpu hangs, so please always attach it.\n");

		warned = true;

	}





	kref_init(&error->ref);

	kref_init(&error->ref);