Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 486f5120 authored by Navid Emamdoost's avatar Navid Emamdoost Committed by Greg Kroah-Hartman
Browse files

scsi: bfa: release allocated memory in case of error 

commit 0e62395da2bd5166d7c9e14cbc7503b256a34cb0 upstream.

In bfad_im_get_stats if bfa_port_get_stats fails, allocated memory needs to
be released.

Link: https://lore.kernel.org/r/20190910234417.22151-1-navid.emamdoost@gmail.com


Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f2bde0e9

drivers/scsi/bfa/bfad_attr.c

+3 −1
Original line number Diff line number Diff line
@@ -283,8 +283,10 @@ bfad_im_get_stats(struct Scsi_Host *shost) 
	rc = bfa_port_get_stats(BFA_FCPORT(&bfad->bfa),

				fcstats, bfad_hcb_comp, &fcomp);

	spin_unlock_irqrestore(&bfad->bfad_lock, flags);

	if (rc != BFA_STATUS_OK)

	if (rc != BFA_STATUS_OK) {

		kfree(fcstats);

		return NULL;

	}



	wait_for_completion(&fcomp.comp);