Commit f2bde0e9 authored Oct 04, 2019 by Navid Emamdoost Committed by Greg Kroah-Hartman Jan 14, 2020

mwifiex: pcie: Fix memory leak in mwifiex_pcie_alloc_cmdrsp_buf



commit db8fd2cde93227e566a412cf53173ffa227998bc upstream.

In mwifiex_pcie_alloc_cmdrsp_buf, a new skb is allocated which should be
released if mwifiex_map_pci_memory() fails. The release is added.

Fixes: fc331460 ("mwifiex: use pci_alloc/free_consistent APIs for PCIe")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: Ganapathi Bhat <gbhat@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 0aa8632c

drivers/net/wireless/marvell/mwifiex/pcie.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1036,8 +1036,10 @@ static int mwifiex_pcie_alloc_cmdrsp_buf(struct mwifiex_adapter *adapter)
		}
		skb_put(skb, MWIFIEX_UPLD_SIZE);
		if (mwifiex_map_pci_memory(adapter, skb, MWIFIEX_UPLD_SIZE,
		PCI_DMA_FROMDEVICE))
		PCI_DMA_FROMDEVICE)) {
		kfree_skb(skb);
		return -1;
		}

		card->cmdrsp_buf = skb;