Commit 35d9e921 authored Jul 31, 2019 by Wang Xiayang Committed by Greg Kroah-Hartman Aug 29, 2019

can: peak_usb: force the string buffer NULL-terminated



[ Upstream commit e787f19373b8a5fa24087800ed78314fd17b984a ]

strncpy() does not ensure NULL-termination when the input string size
equals to the destination buffer size IFNAMSIZ. The output string is
passed to dev_info() which relies on the NULL-termination.

Use strlcpy() instead.

This issue is identified by a Coccinelle script.

Signed-off-by: Wang Xiayang <xywang.sjtu@sjtu.edu.cn>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 895c8fcf

drivers/net/can/usb/peak_usb/pcan_usb_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -863,7 +863,7 @@ static void peak_usb_disconnect(struct usb_interface *intf)

		dev_prev_siblings = dev->prev_siblings;
		dev->state &= ~PCAN_USB_STATE_CONNECTED;
		strncpy(name, netdev->name, IFNAMSIZ);
		strlcpy(name, netdev->name, IFNAMSIZ);

		unregister_netdev(netdev);