Commit 895c8fcf authored Jul 31, 2019 by Wang Xiayang Committed by Greg Kroah-Hartman Aug 29, 2019

can: sja1000: force the string buffer NULL-terminated



[ Upstream commit cd28aa2e056cd1ea79fc5f24eed0ce868c6cab5c ]

strncpy() does not ensure NULL-termination when the input string size
equals to the destination buffer size IFNAMSIZ. The output string
'name' is passed to dev_info which relies on NULL-termination.

Use strlcpy() instead.

This issue is identified by a Coccinelle script.

Signed-off-by: Wang Xiayang <xywang.sjtu@sjtu.edu.cn>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent a3d1263c

drivers/net/can/sja1000/peak_pcmcia.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -487,7 +487,7 @@ static void pcan_free_channels(struct pcan_pccard *card)
		if (!netdev)
		continue;

		strncpy(name, netdev->name, IFNAMSIZ);
		strlcpy(name, netdev->name, IFNAMSIZ);

		unregister_sja1000dev(netdev);