Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3349ed26 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: serial: mos7840: fix remote wakeup 



commit 92fe35fb9c70a00d8fbbf5bd6172c921dd9c7815 upstream.

The driver was setting the device remote-wakeup feature during probe in
violation of the USB specification (which says it should only be set
just prior to suspending the device). This could potentially waste
power during suspend as well as lead to spurious wakeups.

Note that USB core would clear the remote-wakeup feature at first
resume.

Fixes: 3f542974 ("USB: Moschip 7840 USB-Serial Driver")
Cc: stable <stable@vger.kernel.org>     # 2.6.19
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent abbda35d

drivers/usb/serial/mos7840.c

+0 −5
Original line number Diff line number Diff line
@@ -2325,11 +2325,6 @@ static int mos7840_port_probe(struct usb_serial_port *port) 
			goto error;

		} else

			dev_dbg(&port->dev, "ZLP_REG5 Writing success status%d\n", status);



		/* setting configuration feature to one */

		usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),

				0x03, 0x00, 0x01, 0x00, NULL, 0x00,

				MOS_WDR_TIMEOUT);

	}

	return 0;

error: