Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit abbda35d authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: serial: mos7720: fix remote wakeup 



commit ea422312a462696093b5db59d294439796cba4ad upstream.

The driver was setting the device remote-wakeup feature during probe in
violation of the USB specification (which says it should only be set
just prior to suspending the device). This could potentially waste
power during suspend as well as lead to spurious wakeups.

Note that USB core would clear the remote-wakeup feature at first
resume.

Fixes: 0f64478c ("USB: add USB serial mos7720 driver")
Cc: stable <stable@vger.kernel.org>     # 2.6.19
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 84743898

drivers/usb/serial/mos7720.c

+0 −4
Original line number Diff line number Diff line
@@ -1894,10 +1894,6 @@ static int mos7720_startup(struct usb_serial *serial) 
	product = le16_to_cpu(serial->dev->descriptor.idProduct);

	dev = serial->dev;



	/* setting configuration feature to one */

	usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),

			(__u8)0x03, 0x00, 0x01, 0x00, NULL, 0x00, 5000);



	if (product == MOSCHIP_DEVICE_ID_7715) {

		struct urb *urb = serial->port[0]->interrupt_in_urb;