Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27cad008 authored by Radhey Shyam Pandey's avatar Radhey Shyam Pandey Committed by David S. Miller
Browse files

net: emaclite: Fix MDIO bus unregister bug 



Since 'has_mdio' flag is not used,sequence insmod->rmmod-> insmod
leads to failure as MDIO unregister doesn't happen in .remove().
Fix it by checking MII bus pointer instead.

Signed-off-by: default avatarRadhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 087fca59

drivers/net/ethernet/xilinx/xilinx_emaclite.c

+1 −1
Original line number Diff line number Diff line
@@ -1191,7 +1191,7 @@ static int xemaclite_of_remove(struct platform_device *of_dev) 
	struct net_local *lp = netdev_priv(ndev);



	/* Un-register the mii_bus, if configured */

	if (lp->has_mdio) {

	if (lp->mii_bus) {

		mdiobus_unregister(lp->mii_bus);

		mdiobus_free(lp->mii_bus);

		lp->mii_bus = NULL;