Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 087fca59 authored by Radhey Shyam Pandey's avatar Radhey Shyam Pandey Committed by David S. Miller
Browse files

net: emaclite: Fix position of lp->mii_bus assignment 



To ensure MDIO bus is not double freed in remove() path
assign lp->mii_bus after MDIO bus registration.

Signed-off-by: default avatarRadhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4fd44a98

drivers/net/ethernet/xilinx/xilinx_emaclite.c

+2 −2
Original line number Diff line number Diff line
@@ -863,14 +863,14 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) 
	bus->write = xemaclite_mdio_write;

	bus->parent = dev;



	lp->mii_bus = bus;



	rc = of_mdiobus_register(bus, np);

	if (rc) {

		dev_err(dev, "Failed to register mdio bus.\n");

		goto err_register;

	}



	lp->mii_bus = bus;



	return 0;



err_register: