Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 249e573d authored by Linus Walleij's avatar Linus Walleij Committed by Ralf Baechle
Browse files

MIPS: ar7: Be sure to clamp return value 



As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Cc: Alban Bedel <albeu@free.fr>
Cc: linux-mips@linux-mips.org
Cc: linux-gpio@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/11922/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 7b42c00a

arch/mips/ar7/gpio.c

+1 −1
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ static int ar7_gpio_get_value(struct gpio_chip *chip, unsigned gpio) 
				container_of(chip, struct ar7_gpio_chip, chip);

	void __iomem *gpio_in = gpch->regs + AR7_GPIO_INPUT;



	return readl(gpio_in) & (1 << gpio);

	return !!(readl(gpio_in) & (1 << gpio));

}



static int titan_gpio_get_value(struct gpio_chip *chip, unsigned gpio)