Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b42c00a authored by Linus Walleij's avatar Linus Walleij Committed by Ralf Baechle
Browse files

MIPS: Alchemy: Be sure to clamp return value 



As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Cc: linux-mips@linux-mips.org
Cc: linux-gpio@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/11921/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 6d7b1415

arch/mips/alchemy/common/gpiolib.c

+3 −3
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ 


static int gpio2_get(struct gpio_chip *chip, unsigned offset)

{

	return alchemy_gpio2_get_value(offset + ALCHEMY_GPIO2_BASE);

	return !!alchemy_gpio2_get_value(offset + ALCHEMY_GPIO2_BASE);

}



static void gpio2_set(struct gpio_chip *chip, unsigned offset, int value)
@@ -68,7 +68,7 @@ static int gpio2_to_irq(struct gpio_chip *chip, unsigned offset) 


static int gpio1_get(struct gpio_chip *chip, unsigned offset)

{

	return alchemy_gpio1_get_value(offset + ALCHEMY_GPIO1_BASE);

	return !!alchemy_gpio1_get_value(offset + ALCHEMY_GPIO1_BASE);

}



static void gpio1_set(struct gpio_chip *chip,
@@ -119,7 +119,7 @@ struct gpio_chip alchemy_gpio_chip[] = { 


static int alchemy_gpic_get(struct gpio_chip *chip, unsigned int off)

{

	return au1300_gpio_get_value(off + AU1300_GPIO_BASE);

	return !!au1300_gpio_get_value(off + AU1300_GPIO_BASE);

}



static void alchemy_gpic_set(struct gpio_chip *chip, unsigned int off, int v)