Commit 228aa012 authored Nov 14, 2017 by Dan Carpenter Committed by David S. Miller Nov 14, 2017

liquidio: Missing error code in liquidio_init_nic_module()



We accidentally return success if lio_vf_rep_modinit() fails instead of
propogating the error code.

Fixes: e20f4696 ("liquidio: synchronize VF representor names with NIC firmware")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fae45363

drivers/net/ethernet/cavium/liquidio/lio_main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -4038,7 +4038,8 @@ static int liquidio_init_nic_module(struct octeon_device *oct)
		*/
		if (!oct->octeon_id &&
		oct->fw_info.app_cap_flags & LIQUIDIO_SWITCHDEV_CAP) {
		if (lio_vf_rep_modinit()) {
		retval = lio_vf_rep_modinit();
		if (retval) {
		liquidio_stop_nic_module(oct);
		goto octnet_init_failure;
		}