Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fae45363 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

xdp: sample: Missing curly braces in read_route() 



The assert statement is supposed to be part of the else branch but the
curly braces were accidentally left off.

Fixes: 3e29cd0e ("xdp: Sample xdp program implementing ip forward")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4e6759be

samples/bpf/xdp_router_ipv4_user.c

+3 −2
Original line number Original line Diff line number Diff line
@@ -206,13 +206,14 @@ static void read_route(struct nlmsghdr *nh, int nll) 
			direct_entry.arp.mac = 0;

			direct_entry.arp.mac = 0;

			direct_entry.arp.dst = 0;

			direct_entry.arp.dst = 0;

			if (route.dst_len == 32) {

			if (route.dst_len == 32) {

				if (nh->nlmsg_type == RTM_DELROUTE)

				if (nh->nlmsg_type == RTM_DELROUTE) {

					assert(bpf_map_delete_elem(map_fd[3], &route.dst) == 0);

					assert(bpf_map_delete_elem(map_fd[3], &route.dst) == 0);

				else

				} else {

					if (bpf_map_lookup_elem(map_fd[2], &route.dst, &direct_entry.arp.mac) == 0)

					if (bpf_map_lookup_elem(map_fd[2], &route.dst, &direct_entry.arp.mac) == 0)

						direct_entry.arp.dst = route.dst;

						direct_entry.arp.dst = route.dst;

					assert(bpf_map_update_elem(map_fd[3], &route.dst, &direct_entry, 0) == 0);

					assert(bpf_map_update_elem(map_fd[3], &route.dst, &direct_entry, 0) == 0);

				}

				}

			}

			for (i = 0; i < 4; i++)

			for (i = 0; i < 4; i++)

				prefix_key->data[i] = (route.dst >> i * 8) & 0xff;

				prefix_key->data[i] = (route.dst >> i * 8) & 0xff;