Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1735d9e9 authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by Greg Kroah-Hartman
Browse files

staging: i4l: pcbit: layer2: use setup_timer() and mod_timer(). 



Use setup_timer() instead of init_timer(), being the preferred/standard
way to set a timer up.

Also, quoting the mod_timer() function comment:
-> mod_timer() is a more efficient way to update the expire field of an
   active timer (if the timer is inactive it will be activated).

Use setup_timer and mod_timer to setup and arm a timer, to make the code
cleaner and easier to read.

Signed-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8df7a222

drivers/staging/i4l/pcbit/layer2.c

+3 −5
Original line number Diff line number Diff line
@@ -645,11 +645,9 @@ pcbit_l2_error(struct pcbit_dev *dev) 


		dev->l2_state = L2_DOWN;



		init_timer(&dev->error_recover_timer);

		dev->error_recover_timer.function = &pcbit_l2_err_recover;

		dev->error_recover_timer.data = (ulong) dev;

		dev->error_recover_timer.expires = jiffies + ERRTIME;

		add_timer(&dev->error_recover_timer);

		setup_timer(&dev->error_recover_timer, &pcbit_l2_err_recover,

			    (ulong)dev);

		mod_timer(&dev->error_recover_timer, jiffies + ERRTIME);

	}

}