Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8df7a222 authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by Greg Kroah-Hartman
Browse files

staging: i4l: pcbit: edss1: use setup_timer() and mod_timer(). 



Use setup_timer() instead of init_timer(), being the preferred/standard
way to set a timer up.

Also, quoting the mod_timer() function comment:
-> mod_timer() is a more efficient way to update the expire field of an
   active timer (if the timer is inactive it will be activated).

Use setup_timer and mod_timer to setup and arm a timer, to make the code
cleaner and easier to read.

Signed-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fd2b75d8

drivers/staging/i4l/pcbit/edss1.c

+2 −5
Original line number Diff line number Diff line
@@ -298,11 +298,8 @@ void pcbit_fsm_event(struct pcbit_dev *dev, struct pcbit_chan *chan, 
			break;



	if (tentry->init != 0xff) {

		init_timer(&chan->fsm_timer);

		chan->fsm_timer.function = &pcbit_fsm_timer;

		chan->fsm_timer.data = (ulong) chan;

		chan->fsm_timer.expires = jiffies + tentry->timeout * HZ;

		add_timer(&chan->fsm_timer);

		setup_timer(&chan->fsm_timer, &pcbit_fsm_timer, (ulong)chan);

		mod_timer(&chan->fsm_timer, jiffies + tentry->timeout * HZ);

	}



	spin_unlock_irqrestore(&dev->lock, flags);