Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12015964 authored by Sujeev Dias's avatar Sujeev Dias Committed by Gerrit - the friendly Code Review server
Browse files

mhi: core: change to vmalloc for memory allocations larger than 32KB 



Certain large memory allocations are likely to exceed 32KB or
order of 3. It is recommended to switch to using vmalloc instead
to avoid possible failures while allocating memory.

CRs-Fixed: 2446873
Change-Id: I62ddc505956e116f55e8b3b974de3d5b039b0404
Acked-by: default avatarBhaumik Vasav Bhatt <bbhatt@qti.qualcomm.com>
Signed-off-by: default avatarSujeev Dias <sdias@codeaurora.org>
parent fc77ef6b

drivers/bus/mhi/core/mhi_init.c

+5 −5
Original line number Diff line number Diff line
@@ -750,7 +750,7 @@ void mhi_deinit_chan_ctxt(struct mhi_controller *mhi_cntrl, 


	mhi_free_coherent(mhi_cntrl, tre_ring->alloc_size,

			  tre_ring->pre_aligned, tre_ring->dma_handle);

	kfree(buf_ring->base);

	vfree(buf_ring->base);



	buf_ring->base = tre_ring->base = NULL;

	chan_ctxt->rbase = 0;
@@ -775,7 +775,7 @@ int mhi_init_chan_ctxt(struct mhi_controller *mhi_cntrl, 


	buf_ring->el_size = sizeof(struct mhi_buf_info);

	buf_ring->len = buf_ring->el_size * buf_ring->elements;

	buf_ring->base = kzalloc(buf_ring->len, GFP_KERNEL);

	buf_ring->base = vzalloc(buf_ring->len);



	if (!buf_ring->base) {

		mhi_free_coherent(mhi_cntrl, tre_ring->alloc_size,
@@ -989,8 +989,8 @@ static int of_parse_ch_cfg(struct mhi_controller *mhi_cntrl, 
	if (!of_node)

		return -EINVAL;



	mhi_cntrl->mhi_chan = kcalloc(mhi_cntrl->max_chan,

				      sizeof(*mhi_cntrl->mhi_chan), GFP_KERNEL);

	mhi_cntrl->mhi_chan = vzalloc(mhi_cntrl->max_chan *

				      sizeof(*mhi_cntrl->mhi_chan));

	if (!mhi_cntrl->mhi_chan)

		return -ENOMEM;
@@ -1137,7 +1137,7 @@ static int of_parse_ch_cfg(struct mhi_controller *mhi_cntrl, 
	return 0;



error_chan_cfg:

	kfree(mhi_cntrl->mhi_chan);

	vfree(mhi_cntrl->mhi_chan);



	return -EINVAL;

}