Commit 0901df3a authored Jan 26, 2017 by Daniel Borkmann Committed by David S. Miller Jan 25, 2017

bpf: use prefix_len in test_tag when reading fdinfo



We currently used len instead of prefix_len for the strncmp() in
fdinfo on the prog_tag. It still worked as we matched on the correct
output line also with first 8 instead of 10 chars, but lets fix it
properly to use the intended length.

Fixes: 62b64660 ("bpf: add prog tag test case to bpf selftests")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1541f98c

tools/testing/selftests/bpf/test_tag.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -99,7 +99,7 @@ static void tag_from_fdinfo(int fd_prog, uint8_t *tag, uint32_t len)
		assert(fp);

		while (fgets(buff, sizeof(buff), fp)) {
		if (strncmp(buff, "prog_tag:\t", len))
		if (strncmp(buff, "prog_tag:\t", prefix_len))
		continue;
		ret = hex2bin(tag, buff + prefix_len, len);
		break;